This proposal has been implemented

This incidence has been solved. Closed via #4850.

Thank you for contributing!

The video is not shown in the description of the debate

Finished

Pau Parals Decidim Member 23/01/2019 11:24

When I use an embed url I hope the video will be displayed in the description of the debate. In this case, it only appears on the card. We should use a reflector in decidim_sanitize instead of simple_format.

Filter results for: 0.16.x

Comment

Comment details

You are seeing a single comment

View all comments

Oriol

14/02/2019 12:05

Against

I don't think this is actually a bug (and especially not related to 0.16 since it's been working like this for many months), in any case, it would be an enhancement.

The problem I'm seeing is allowing inserting any kind of iframe in the description of a debate (or other parts), this could potentially lead to spam or even malicious uses.

I'd actually remove embedding an iframe inside the card.

Pau Parals Decidim Member

14/02/2019 12:21

It is a bug from the moment the user is allowed to insert a video iframe and is not rendered in the public part. Otherwise, it would not make sense for the user to do this.

On the other hand, to avoid spam or malicious uses, the video iframe could be restricted to the administrator and not to the participants.

Oriol

14/02/2019 17:08

The problem is allowing to add any iframe content, I’m against that and I think we should remove it.

Also, even in the case that we allowed videos I wouldn’t show them in the card.

And if we only allow admins to do it, this would be (to me) a new feature, since initially you couldn’t embed an iframe, and this bug is a side effect of allowing it.

Pau Parals Decidim Member

14/02/2019 17:14

Exact. For me, it is a bug that is not currently displayed on the public side, since both delete iframe content or allow admins is a new functionality.

Oriol

15/02/2019 09:27

I'll update how debates are rendered for consistency but I think we should revisit the fact that iframes can be shown at cards and that you can embed any type of content.

Reference: MDC-PROP-2019-01-14192
Version number 1 (of 1) see other versions

Essential

Preferences

Analytics and statistics

Marketing

The video is not shown in the description of the debate

Please log in

Cookie settings

Essential

Preferences

Analytics and statistics

Marketing

The video is not shown in the description of the debate

Share

QR Code

The video is not shown in the description of the debate

Confirm

Please log in