Proposa noves funcionalitats
#DecidimRoadmap Dissenyant el Decidim entre totes
Is your feature request related to a problem? A clear and concise description of what the problem is.
We've had this request by a couple clients. It's also in the Decidim Awesome roadmap.
Now that comments have be re-written in rails it's possible to enhance the comment function.
Describe the solution you'd like
As an admin I want to be able to enable attachement in comments using a config flag on the components config
As a user adding a comment when attachements are enabled I have an upload button bellow the text field. Once the comment is published the attachement displays under the text as link inside an attachement box. (See attachements)
Describe alternatives you've considered
No
Additional context
Comment were re-written in rails : https://meta.decidim.org/processes/roadmap/f/122/proposals/14369 https://github.com/decidim/decidim/pull/6498
Does this issue could impact on users private data?
No
Funded by
Might be funded by CNRHR
Imatges relacionades
Reportar contingut inapropiat
Aquest contingut no és apropiat?
9 comentaris
Conversa amb Virgile Deville
@microstudi this discussion might interest you
@ahu also I think
Conversa amb Virgile Deville
@carol would product be open to this ?
Hey @virgile_deville, we''ll be happy to incorporate this, but not now. Better to wait for the upgrade to Rails 6 since we will be able to integrate the Trix editor, which already comes with ActiveStorage :)
Ok thanks for your answer.
Just to chime in about the Trix editor. I don't know if the decision is already taken, but I would invite to do some serious analysis and testing. In Populate we have been using it in several projects and I'm not sure I would select it for a project as Decidim. The main difficulty is the management of embeds/iframes, ie. Youtube. For this you have to do a specific implementation, which is a bit weird. You managed to do it, but it was not easy nor clean.
@virgile_deville I'll incorporate this when 0.24 is out in Awesome. Basically because I don't want to deal with the React stuff.
Conversa amb Antti Hukkanen
Virgile: Haven't heard this request but I think it would be warmly welcomed.
I'd prefer to have something similar to GitHub issue attachments/images, so you could possibly add more than 1. But that requires having this possibility in the editor as Carol mentioned. After ActiveStorage is introduced to Decidim, it should become easier to add this feature (Trix not necessary but ActiveStorage would make it easier to upload and store files dynamically).
Only thing I'm concerned about is accessibility. Accessibility requirements require every image and attachment having an alternative text/title defined for them. The UI should ask the user to give a title for the attachment after its upload. GitHub issue comments default to the original file name of the uploaded file.
Furilo also raises a very good point about introducing Trix. It should be heavily tested before introduction so we don't find similar pitfalls with it as with quill.js.
By the way the (at) mentions seem to constantly break sending comments. I get HTTP 422.
I tried to send this message with the names (Virgile, Carol and Furtilo) replaced with (at) mentions and it won't accept my comment. Everything is fine after removing the mentions.
Deixa el teu comentari
Inicia la sessió amb el teu compte o registra't per afegir el teu comentari.
Carregant els comentaris ...