Aquest lloc web fa servir cookies pròpies i de tercers per millorar l’experiència de navegació, i oferir continguts i serveis d’interès. En continuar la navegació entenem que acceptes la nostra política de cookies. Per a més informació consulta aquí.
Vés al contingut principal
Logo oficial de Metadecidim
  • Català Triar la llengua Elegir el idioma Choose language
    • Castellano
    • English
Registra't Entra
  • Inici
  • Processos
  • Assemblees
  • Iniciatives
  • Consultes
  • Jornades
  • Ajuda

Proposa noves funcionalitats

#DecidimRoadmap Dissenyant el Decidim entre totes

Fase 1 de 1
Obert 01-01-2019 - 31-12-2030
Veure les fases Envia una proposta
  • El procés
  • Debats
  • Proposa noves funcionalitats
  • Novetats
chevron-left Torna al llistat

Allow attachements in comments

Avatar: Virgile Deville Virgile Deville
23/11/2020 20:17  

Is your feature request related to a problem? A clear and concise description of what the problem is.

We've had this request by a couple clients. It's also in the Decidim Awesome roadmap.

Now that comments have be re-written in rails it's possible to enhance the comment function.

Describe the solution you'd like

As an admin I want to be able to enable attachement in comments using a config flag on the components config

As a user adding a comment when attachements are enabled I have an upload button bellow the text field. Once the comment is published the attachement displays under the text as link inside an attachement box. (See attachements)

Describe alternatives you've considered

No

Additional context

Comment were re-written in rails : https://meta.decidim.org/processes/roadmap/f/122/proposals/14369 https://github.com/decidim/decidim/pull/6498

Does this issue could impact on users private data?

No

Funded by

Might be funded by CNRHR

  • Resultats al filtrar per la categoria: Comentaris deliberatius Comentaris deliberatius

Llistat d'adhesions

Avatar: Michele Pablo Silva Michele Pablo Silva
Avatar: Klaar Klaar
Número d'adhesions2
Allow attachements in comments Comentaris 9

Referència: MDC-PROP-2020-11-15810
Versió 1 (de 1) veure altres versions
Verifica l'empremta digital

Empremta digital

El text següent és una representació abreviada i hashejada d'aquest contingut. És útil per garantir que el contingut no hagi estat alterat, ja que una única modificació provocaria un valor totalment diferent.

Valor: db62c2812304872a169516d1b5ffd24d431495d8a0363383dd749c5cccaec5f3

Origen: {"body":{"en":"<p><strong>Is your feature request related to a problem? A clear and concise description of what the problem is.</strong></p><p>We've had this request by a couple clients. It's also in the Decidim Awesome roadmap.</p><p>Now that comments have be re-written in rails it's possible to enhance the comment function.</p><p><strong>Describe the solution you'd like</strong></p><p>As an admin I want to be able to enable attachement in comments using a config flag on the components config</p><p>As a user adding a comment when attachements are enabled I have an upload button bellow the text field. Once the comment is published the attachement displays under the text as link inside an attachement box. (See attachements)</p><p><strong>Describe alternatives you've considered</strong></p><p>No</p><p><strong>Additional context</strong></p><p>Comment were re-written in rails : <a href=\"https://meta.decidim.org/processes/roadmap/f/122/proposals/14369\" target=\"_blank\">https://meta.decidim.org/processes/roadmap/f/122/proposals/14369</a> <a href=\"https://github.com/decidim/decidim/pull/6498\" target=\"_blank\">https://github.com/decidim/decidim/pull/6498</a></p><p><strong>Does this issue could impact on users private data?</strong></p><p>No</p><p><strong>Funded by</strong></p><p>Might be funded by CNRHR</p>"},"title":{"en":"Allow attachements in comments"}}

Aquesta empremta digital es calcula mitjançant un algoritme de hash SHA256. Per reproduir-lo tu mateix, pots utilitzar una Calculadora MD5 en línia i copiar-hi les dades d'origen.

Compartir:

link-intact Compartir l'enllaç

Compartir l'enllaç:

Si us plau, enganxa aquest codi a la teva pàgina:

<script src="https://meta.decidim.org/processes/roadmap/f/122/proposals/15810/embed.js?locale=ca"></script>
<noscript><iframe src="https://meta.decidim.org/processes/roadmap/f/122/proposals/15810/embed.html?locale=ca" frameborder="0" scrolling="vertical"></iframe></noscript>

Imatges relacionades

comments-attachement.png
Capture d’écran 2020-11-23 à 19.36.26.png

Reportar contingut inapropiat

Aquest contingut no és apropiat?

Motiu

9 comentaris

Ordenar per:
  • Més antic
    • Més ben valorats
    • Recent
    • Més antic
    • Més discutit
Conversa amb Virgile Deville
Avatar: Virgile Deville Virgile Deville
23/11/2020 20:17
  • Obtenir enllaç Obtenir enllaç

@microstudi this discussion might interest you

Avatar: Virgile Deville Virgile Deville
24/11/2020 08:58
  • Obtenir enllaç Obtenir enllaç

@ahu also I think

Conversa amb Virgile Deville
Avatar: Virgile Deville Virgile Deville
23/11/2020 20:18
  • Obtenir enllaç Obtenir enllaç

@carol would product be open to this ?

Avatar: Carol Romero Carol Romero verified-badge
24/11/2020 10:30
  • Obtenir enllaç Obtenir enllaç

Hey @virgile_deville, we''ll be happy to incorporate this, but not now. Better to wait for the upgrade to Rails 6 since we will be able to integrate the Trix editor, which already comes with ActiveStorage :)

Avatar: Virgile Deville Virgile Deville
24/11/2020 10:44
  • Obtenir enllaç Obtenir enllaç

Ok thanks for your answer.

Avatar: álvaro ortiz álvaro ortiz verified-badge
24/11/2020 10:50
  • Obtenir enllaç Obtenir enllaç

Just to chime in about the Trix editor. I don't know if the decision is already taken, but I would invite to do some serious analysis and testing. In Populate we have been using it in several projects and I'm not sure I would select it for a project as Decidim. The main difficulty is the management of embeds/iframes, ie. Youtube. For this you have to do a specific implementation, which is a bit weird. You managed to do it, but it was not easy nor clean.

Avatar: Ivan Vergés Ivan Vergés verified-badge
24/11/2020 10:37
  • Obtenir enllaç Obtenir enllaç

@virgile_deville I'll incorporate this when 0.24 is out in Awesome. Basically because I don't want to deal with the React stuff.

Conversa amb Antti Hukkanen
Avatar: Antti Hukkanen Antti Hukkanen
24/11/2020 15:59
  • Obtenir enllaç Obtenir enllaç

Virgile: Haven't heard this request but I think it would be warmly welcomed.

I'd prefer to have something similar to GitHub issue attachments/images, so you could possibly add more than 1. But that requires having this possibility in the editor as Carol mentioned. After ActiveStorage is introduced to Decidim, it should become easier to add this feature (Trix not necessary but ActiveStorage would make it easier to upload and store files dynamically).

Only thing I'm concerned about is accessibility. Accessibility requirements require every image and attachment having an alternative text/title defined for them. The UI should ask the user to give a title for the attachment after its upload. GitHub issue comments default to the original file name of the uploaded file.

Furilo also raises a very good point about introducing Trix. It should be heavily tested before introduction so we don't find similar pitfalls with it as with quill.js.

Avatar: Antti Hukkanen Antti Hukkanen
24/11/2020 16:00
  • Obtenir enllaç Obtenir enllaç

By the way the (at) mentions seem to constantly break sending comments. I get HTTP 422.

I tried to send this message with the names (Virgile, Carol and Furtilo) replaced with (at) mentions and it won't accept my comment. Everything is fine after removing the mentions.

Deixa el teu comentari

Inicia la sessió amb el teu compte o registra't per afegir el teu comentari.

Carregant els comentaris ...

  • Termes i condicions d'ús
  • Sobre la comunitat
  • Descarrega els fitxers de dades obertes
  • Metadecidim a Twitter Twitter
  • Metadecidim a Instagram Instagram
  • Metadecidim a YouTube YouTube
  • Metadecidim a GitHub GitHub
Amb llicència Creative Commons Web creada amb programari lliure.
Logo Decidim

Confirmar

D'acord Cancel·lar

Si us plau, inicia sessió

decidim Inicia sessió amb Decidim
O

Registra't

Has oblidat la teva contrasenya?