This site uses cookies. By continuing to browse the site, you agree to our use of cookies. Find out more about cookies.
Skip to main content
Metadecidim's official logo
  • English Triar la llengua Elegir el idioma Choose language
    • Català
    • Castellano
Sign Up Sign In
  • Home
  • Processes
  • Assemblies
  • Initiatives
  • Consultations
  • Conferences
  • Help

Report a Bug

#BugReportDecidim Let's test Decidim and report bugs together

  • The process
  • I found a Bug!
chevron-left Back to list

Linking to other modules than proposals in comments always leads to proposal links

Avatar: Antti Hukkanen Antti Hukkanen
18/03/2019 13:52  
Accepted

Currently the proposal parser for comments always assumes the URLs formatted as the proposal URLs are links to proposals:
https://github.com/decidim/decidim/blob/master/decidim-proposals/lib/decidim/content_parsers/proposal_parser.rb

This will for example match the following URLs:
https://decidim.lvh.me/processes/example/f/1/proposals/123
https://decidim.lvh.me/processes/example/f/1/plans/123
https://decidim.lvh.me/processes/example/f/1/whatever-here/123

As you see from the URLs, the items can also be something else than proposals, even though they may have same IDs as proposals (as they are completely separate entities).

This parser should consider that there may be other components that have URLs of similar structure. In such case, the parser makes it impossible to link to any other resources that have same primary IDs as existing proposals.

  • Filter results for category: 0.16.x 0.16.x

This proposal has been accepted because:

This incidence has been solved. Closed via #4978.

Thank you for contributing!

Endorsements count0
Linking to other modules than proposals in comments always leads to proposal links Comments 2

Reference: MDC-PROP-2019-03-14311
Version number 1 (of 1) see other versions
Check fingerprint

Fingerprint

The piece of text below is a shortened, hashed representation of this content. It's useful to ensure the content hasn't been tampered with, as a single modification would result in a totally different value.

Value: c55a17eb0800340ed2f643411f10d3565a176e821afcb393b23ef98599ebcfdb

Source: {"body":{"en":"Currently the proposal parser for comments always assumes the URLs formatted as the proposal URLs are links to proposals:\r\nhttps://github.com/decidim/decidim/blob/master/decidim-proposals/lib/decidim/content_parsers/proposal_parser.rb\r\n\r\nThis will for example match the following URLs:\r\nhttps://decidim.lvh.me/processes/example/f/1/proposals/123\r\nhttps://decidim.lvh.me/processes/example/f/1/plans/123\r\nhttps://decidim.lvh.me/processes/example/f/1/whatever-here/123\r\n\r\nAs you see from the URLs, the items can also be something else than proposals, even though they may have same IDs as proposals (as they are completely separate entities).\r\n\r\nThis parser should consider that there may be other components that have URLs of similar structure. In such case, the parser makes it impossible to link to any other resources that have same primary IDs as existing proposals."},"title":{"en":"Linking to other modules than proposals in comments always leads to proposal links"}}

This fingerprint is calculated using a SHA256 hashing algorithm. In order to replicate it yourself, you can use an MD5 calculator online and copy-paste the source data.

Share:

link-intact Share link

Share link:

Please paste this code in your page:

<script src="https://meta.decidim.org/processes/bug-report/f/210/proposals/14311/embed.js"></script>
<noscript><iframe src="https://meta.decidim.org/processes/bug-report/f/210/proposals/14311/embed.html" frameborder="0" scrolling="vertical"></iframe></noscript>

Report inappropriate content

Is this content inappropriate?

Reason

Comment details

Order by:
  • Older
    • Best rated
    • Recent
    • Older
    • Most discussed
You are seeing a single comment

View all comments

Avatar: Carol Romero Carol Romero verified-badge
01/04/2019 10:26
  • Get link Get link

Thanks for your PR @ahu!

Loading comments ...

  • Terms and conditions of use
  • About the community
  • Download Open Data files
  • Metadecidim at Twitter Twitter
  • Metadecidim at Instagram Instagram
  • Metadecidim at YouTube YouTube
  • Metadecidim at GitHub GitHub
Creative Commons License Website made with free software.
Decidim Logo

Confirm

OK Cancel

Please sign in

decidim Sign in with Decidim Barcelona
Or

Sign up

Forgot your password?