This site uses cookies. By continuing to browse the site, you agree to our use of cookies. Find out more about cookies.
Skip to main content
Metadecidim's official logo
  • English Triar la llengua Elegir el idioma Choose language
    • Català
    • Castellano
Sign Up Sign In
  • Home
  • Processes
  • Assemblies
  • Initiatives
  • Consultations
  • Conferences
  • Help

Propose new functionalities for Decidim software

#DecidimRoadmap Designing Decidim together

Phase 1 of 1
Open 2019-01-01 - 2030-12-31
Process phases Submit a proposal
  • The process
  • Debates
  • Propose new features
  • News
chevron-left Back to list

Rewrite comments in Rails

Avatar: Marc Riera Marc Riera
01/04/2019 11:10  
Finished

Currently, comments are written in React, using TypeScript + the GraphQL API. this seemed like a good idea in the beginning, but currently adds a lot of complexity to the system:

1. Comments is the only piece of Decidim that actively uses the API. This forces the new developers to learn yet another piece of software, steeping the learning curve.
2. Comments use TypeScript instead of bare JS. This adds type safety, but steepens the learning curve.
3. In development, the API breaks. This is not a Decidim problem per se, it's a bug on the library we use to develop the API, but again it makes it harder to develop.

All this makes it harder to modify/improve the comments section, but we'd reduce a lot of lines of code, we'd slim dependencies down and we'd remove some complexity. Also, we'd gain some consistency in development.

The downside is that this could be a big refactor, but I think it's a nice investment.

  • Filter results for category: Comments and deliberation Comments and deliberation

The development of this proposal has finished

  • Reviewed by @product and included in Decidim Roadmap
  • It is funded by Mainio Tech
  • Developed by Mainio Tech
  • Available in release 0.24 via #6498

List of Endorsements

Avatar: Armand Armand
Avatar: Marc Riera Marc Riera
Avatar: agustibr ☂️ agustibr ☂️ verified-badge
Avatar: Aitor Lopez Beltran Aitor Lopez Beltran
Avatar: Antti Hukkanen Antti Hukkanen
Avatar: Ivan Vergés Ivan Vergés verified-badge
Avatar: olivier olivier
Avatar: Pierre Mesure Pierre Mesure verified-badge
and 5 more people (see more) (see less)
Endorsements count8
Rewrite comments in Rails Comments 5

Reference: MDC-PROP-2019-04-14369
Version number 2 (of 2) see other versions
Check fingerprint

Fingerprint

The piece of text below is a shortened, hashed representation of this content. It's useful to ensure the content hasn't been tampered with, as a single modification would result in a totally different value.

Value: 2d6fb4d90b99c2b317a68d9914ab397484373d85a53c3c75fb5af88d65e82086

Source: {"body":{"en":"Currently, comments are written in React, using TypeScript + the GraphQL API. this seemed like a good idea in the beginning, but currently adds a lot of complexity to the system:\r\n\r\n1. Comments is the only piece of Decidim that actively uses the API. This forces the new developers to learn yet another piece of software, steeping the learning curve.\r\n2. Comments use TypeScript instead of bare JS. This adds type safety, but steepens the learning curve.\r\n3. In development, the API breaks. This is not a Decidim problem per se, it's a bug on the library we use to develop the API, but again it makes it harder to develop.\r\n\r\nAll this makes it harder to modify/improve the comments section, but we'd reduce a lot of lines of code, we'd slim dependencies down and we'd remove some complexity. Also, we'd gain some consistency in development.\r\n\r\nThe downside is that this could be a big refactor, but I think it's a nice investment."},"title":{"en":"Rewrite comments in Rails"}}

This fingerprint is calculated using a SHA256 hashing algorithm. In order to replicate it yourself, you can use an MD5 calculator online and copy-paste the source data.

Share:

link-intact Share link

Share link:

Please paste this code in your page:

<script src="https://meta.decidim.org/processes/roadmap/f/122/proposals/14369/embed.js"></script>
<noscript><iframe src="https://meta.decidim.org/processes/roadmap/f/122/proposals/14369/embed.html" frameborder="0" scrolling="vertical"></iframe></noscript>

Report inappropriate content

Is this content inappropriate?

Reason

Comment details

Order by:
  • Older
    • Best rated
    • Recent
    • Older
    • Most discussed
You are seeing a single comment

View all comments

Avatar: agustibr ☂️ agustibr ☂️ verified-badge
08/04/2019 13:26
  • Get link Get link
In favor  

I agree

Loading comments ...

  • Terms and conditions of use
  • About the community
  • Download Open Data files
  • Metadecidim at Twitter Twitter
  • Metadecidim at Instagram Instagram
  • Metadecidim at YouTube YouTube
  • Metadecidim at GitHub GitHub
Creative Commons License Website made with free software.
Decidim Logo

Confirm

OK Cancel

Please sign in

decidim Sign in with Decidim Barcelona
Or

Sign up

Forgot your password?