Skip to main content

Cookie settings

We use cookies to ensure the basic functionalities of the website and to enhance your online experience. You can choose for each category to opt-in/out whenever you want.

Essential

Preferences

Analytics and statistics

Marketing

Changes at "Custom icons in my Home Screen"

Avatar: AndrƩs AndrƩs

Title

  • +{"en"=>"Custom icons in my Home Screen"}

Body

  • +["

    Ref. PWA09

    NOTE: this feature is from a big development. See PWA discussion at GitHub.

    Is your feature request related to a problem? Please describe.
    As a visitor with an iPhone after Iā€™ve added it to my iOS home screen, I want to see this icon with a nice resolution.

    Describe the solution youā€™d like
    I want to have the apple-touch-icon meta tag. It should have 180x180 pixels.

    As we already have a Favicon field in Organization -> Appearance, weā€™re going to reuse that.

    We will also implement some of the recommended sizes in the EvilMartiansā€™ Favicon guide. Mind that for simplicity weā€™ve dropped the SVG format. Sizes will be 32x32, 180x180, 192x192 and 512x512.

    The help text of this field will be:

    Guidance for file:

    • Has to be a square image.
    • The recommended size for this image is 512x512.
    • Accepted formats: png
    • This image will be: Resized and padded to 192x192, 180x180, and 32x32.

    As this is potentially a breaking change for legacy apps this change should be explained in the CHANGELOG:

    As of PR XXX, we now only allow PNG images at Favicon so we can provide higher quality versions to mobile devices.

    Describe alternatives youā€™ve considered
    We could have lots of uploads fields for different kinds of favicons, but thatā€™s overkill.

    We could transform it to SVG also as the linked article mentions, but thatā€™s too much.

    Additional context

    https://web.dev/apple-touch-icon/

    Does this issue could impact on users private data?
    No, itā€™s about icons

    Acceptance criteria

    • Given that Iā€™m an administrator
      When I go to the Organization -> Appearance admin page
      Then I see the following help in the Favicon section:

    Guidance for file:

    • Accepted format: png
    • The recommended shape for this image is a square.
    • The recommended size for this image is 512x512.
    • This image will be: Resized and padded to 192x192, 180x180, and 32x32.
    • Given that Iā€™m a visitor and an administrator uploaded a 512x512 PNG image in this field
      When I check the source code
      Then I can see that thereā€™s this meta tag: <link rel=\"icon\" href=\"/favicon.ico\" sizes=\"any\">
      and that the original image was resized to 32Ɨ32.
    • Given that Iā€™m a visitor and an administrator uploaded a 512x512 PNG image in this field
      When I check the source code
      Then I can see that thereā€™s this meta tag: <link rel=\"apple-touch-icon\" href=\"/apple-touch-icon.png\">
      and that the original image was resized to 180x180.
    • Given that Iā€™m a visitor and an administrator uploaded a 512x512 PNG image in this field
      When I check the manifest file
      Then I can see that thereā€™s an icon key with the 192x192 and 512x512 properties
      And that these icons were resized to their corresponding sizes.
    • Given that Iā€™m an implementer
      When I go to CHANGELOG.md
      Then I see a message that says that ā€œwe now only allow PNG images at Favicon so we can provide higher quality versions to mobile devicesā€
    • Given that Iā€™m an implementer
      When I generate a new application
      and I go to /system
      Then I see that there isnā€™t the ICO extension anymore


    "]

Confirm

Please log in

The password is too short.

Share