This site uses cookies. By continuing to browse the site, you agree to our use of cookies. Find out more about cookies.
#DecidimFest20 - 18-20 nov
Decidim's official logo

Report a Bug

#BugReportDecidim Let's test Decidim and report bugs together

Phase 1 of 1
Open 2019-01-01 - 2019-12-31
Process phases Report a bug

Changes at "Return 404 if user does not exist"

Compare view mode:
HTML view mode:

Title

  • +Return 404 if user does not exist
  • +Return 404 if user does not exist
Deletions
Additions
Deletions
Additions
  • +Return 404 if user does not exist

Body

  • +Our error reporting tool is registering HTTP 500 errors because a webcrawler is visiting the profile activity of users that do no longer exist, and when rendering the page an Exception is raised.
  • +
  • +The affected URL is https://*domain*/profiles/*nickname*/activity
  • +
  • +I suggest returning a 404 instead. For that we just have to change find_by per find_by! here:
  • +
  • +https://github.com/decidim/decidim/blob/master/decidim-core/app/controllers/decidim/user_activities_controller.rb#L15
  • +Our error reporting tool is registering HTTP 500 errors because a webcrawler is visiting the profile activity of users that do no longer exist, and when rendering the page an Exception is raised.
  • +
  • +The affected URL is https://*domain*/profiles/*nickname*/activity
  • +
  • +I suggest returning a 404 instead. For that we just have to change find_by per find_by! here:
  • +
  • +https://github.com/decidim/decidim/blob/master/decidim-core/app/controllers/decidim/user_activities_controller.rb#L15
Deletions
Additions
Deletions
Additions
  • +Our error reporting tool is registering HTTP 500 errors because a webcrawler is visiting the profile activity of users that do no longer exist, and when rendering the page an Exception is raised.
  • +
  • +The affected URL is https://*domain*/profiles/*nickname*/activity
  • +
  • +I suggest returning a 404 instead. For that we just have to change find_by per find_by! here:
  • +
  • +https://github.com/decidim/decidim/blob/master/decidim-core/app/controllers/decidim/user_activities_controller.rb#L15
Version number 1 out of 1 Show all versions Go back to proposal
Version author
author-avatar Alberto Miedes Garcés
Version created at 02/12/2019 09:12
Aquest projecte està cofinançat pel Fons Europeu de Desenvolupament Regional de la Unió Europea.
FEDER
Creative Commons License Website made with free software.

Please sign in

Forgot your password?

Or